The vote passed with the following +1's: Binding (PMC): Nate Cole Jonathan Hurley
Non-binding: Sandor Molnar Attila Doroszlai Krisztian Kasa Balazs Bence Sari Dmytro Grinenko I will follow-up with Apache Infra to move the ASF Github Bot comments to the Worklog section in JIRA. Thank you, Vivek Ratnavel On Wed, Jan 10, 2018 at 5:24 AM, Dmytro Grinenko <[email protected]> wrote: > +1 > > > "although it seems to me like a workaround, the best thing probably would > be to add the patch as an attachment" > > Is there any need on that? Afaik any pull request stay in git while repo > is hosted on git, and any patch/diff from pull request could be downloaded > using pull id. > > > For example AMBARI-22739: > > Curl https://api.github.com/repos/apache/ambari/pulls/72 will show: > > "diff_url": "https://github.com/apache/ambari/pull/72.diff";, > "patch_url": "https://github.com/apache/ambari/pull/72.patch"; > > I.e. diff or patch could be always be downloaded using url pattern above. > As a solution, we could create links for them in jira, instead of attaching > them > > -----Original Message----- > From: Balazs Bence Sari [mailto:[email protected]] > Sent: Wednesday, January 10, 2018 11:29 AM > To: [email protected] > Subject: Re: [VOTE] Move ASF Github Bot comments to Worklog in JIRA > > +1 (although it seems to me like a workaround, the best thing probably > would be to add the patch as an attachment) > > > > > > On 1/10/18, 10:15, "Krisztian Kasa" <[email protected]> wrote: > > >+1 > > > >On Jan 9, 2018, at 8:04 PM, Vivek Ratnavel <[email protected]< > mailto:[email protected]>> wrote: > > > >Hi Team, > > > >The Apache Ambari repository was moved to gitbox yesterday for deeper > integration with github and folks have started using github for review and > merge of patches. If you are unsure of any step, please read the updated > How to Contribute<https://cwiki.apache.org/confluence/display/ > AMBARI/How+to+Contribute> guide. > > > >With JIRA linking enabled on Github pull requests, the ASF Github Bot > automatically posts several messages as comments in the related JIRA. Check > this JIRA for example - https://issues.apache.org/jira/browse/AMBARI-22739. > While it is nice to have these comments, we don't want to pollute the > comments section of JIRA. When I contacted Apache Infra team on this issue, > they suggested that there is an option to push these messages to "Worklog" > section of JIRA which made sense to me. > > > >I am starting this thread to get your vote on moving ASF Github Bot > comments to "Worklog" section in JIRA. > > > >[cid:ii_jc808qxg0_160dc4eda9a1917b] > > > >Thanks, > >Vivek Ratnavel​ > > >
