Nate, I agree with you and Jonathan about limiting the weaver. However, I think that should apply to all builds, ie. for you and me locally, too. This thread is about tweaking the Jenkins jobs where possible without changing global settings for everyone.
So I created a task for the weave change: https://issues.apache.org/jira/browse/AMBARI-23190 -Attila On Fri, Mar 9, 2018 at 3:18 PM, Nate Cole <[email protected]> wrote: > Attila, > > I would also ask that you limit the packages that the weaver works on - like > just the orm package. > > We shouldn't be doing the whole tree. > > On 3/8/18, 9:46 AM, "Doroszlai, Attila" <[email protected]> wrote: > > Thanks, Yusaku. > > I have updated the Jenkins jobs with the -Del.log=WARN argument. Now > logs are down to 3MB. > > I'd like to get approval for the following changes (improvements in my > opinion): > > 1. Add timestamps to Maven output. This would help us track down > cases when the build is aborted due to timeout, eg. most recently > https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1041/ > I think the default "milliseconds since start of build" format would > be fine. Example: > > 977 [INFO] Scanning for projects... > 1432 [INFO] > ------------------------------------------------------------------------ > 1432 [INFO] Reactor Build Order: > ... > 107797 [INFO] BUILD SUCCESS > 107797 [INFO] > ------------------------------------------------------------------------ > 107797 [INFO] Total time: 01:46 min > > 2. Remove the "v" option from extraction of > node-v4.5.0-linux-x64.tar.gz ("tar xzvf"). We always get the same > 350KB of output. > > 3. Add "-Drat.consoleOutput=true" to the Maven command. Currently RAT > check only shows the number of files with unapproved licenses. It > puts details in target/rat.txt, which as far as I know we have no > access to. This option makes RAT print the names of offending files > in the build output. Normally there no offenders, but in the case > when there are, I think this would speed up resolution a bit. > > Please let me know what you think. > > -Attila > > On Tue, Mar 6, 2018 at 9:25 PM, Yusaku Sako <[email protected]> > wrote: > > Hi Attila, > > > > I have given you access to modify Jenkins build jobs. > > Please go ahead and make necessary changes. > > > > Thanks, > > Yusaku > > > > On 3/6/18, 11:26 AM, "Doroszlai, Attila" <[email protected]> wrote: > > > > Yusaku, could you please make the change, or ask someone with access > > to Jenkins to do it? > > > > Thanks. > > > > -Attila > > > > On Thu, Feb 15, 2018 at 5:27 PM, Jonathan Hurley > > <[email protected]> wrote: > > > +1 as well. > > > > > > Could we also set a property so that it doesn't try to weave > every since class? Can we scope it only to the ORM classes? > > > > > >> On Feb 15, 2018, at 11:16 AM, Yusaku Sako > <[email protected]> wrote: > > >> > > >> +1 on changing log level. Good idea. > > >> > > >> Yusaku > > >> > > >> On 2/15/18, 8:02 AM, "Doroszlai, Attila" <[email protected]> > wrote: > > >> > > >> Hi, > > >> > > >> The output of each Ambari build contains almost 20K lines > (3.4 MB) for > > >> the eclipselink-staticweave-maven-plugin (see example below). > I doubt > > >> anyone ever reads these. > > >> > > >> I'd like to propose turning it lower in the pre/post-commit > Jenkins > > >> jobs, to only show warnings or errors. This can be achieved > by > > >> passing -Del.log=WARN to mvn (on branch-2.5 and above). > > >> > > >> Setting it to WARN would leave us with only 6 warnings on > trunk, which > > >> probably nobody noticed, as they are buried among the other > 19922 > > >> lines. > > >> > > >> * > https://builds.apache.org/view/A/view/Ambari/job/Ambari-branch-2.6/ > > >> * > https://builds.apache.org/view/A/view/Ambari/job/Ambari-Github-PullRequest-Builder/ > > >> * > https://builds.apache.org/view/A/view/Ambari/job/Ambari-trunk-Commit/ > > >> > > >> Thanks. > > >> > > >> -Attila > > >> > > >> > > >> [EL Finest]: jpa: 2018-01-19 > > >> > 14:43:44.659--ServerSession(1245802592)--Thread(Thread[main,5,main])--Begin > > >> predeploying Persistence Unit ambari-server; session > ambari-server; > > >> state Initial; factoryCount 0 > > >> [EL Finest]: properties: 2018-01-19 > > >> > 14:43:44.693--ServerSession(1245802592)--Thread(Thread[main,5,main])--property=eclipselink.weaving.changetracking; > > >> default value=true > > >> [EL Finest]: properties: 2018-01-19 > > >> > 14:43:44.693--ServerSession(1245802592)--Thread(Thread[main,5,main])--property=eclipselink.weaving.lazy; > > >> default value=true > > >> > > >> > > >> > > > > > > > > > > > >
