jojochuang commented on code in PR #3356:
URL: https://github.com/apache/ambari/pull/3356#discussion_r971405795
##########
ambari-server/src/main/java/org/apache/ambari/server/api/AmbariViewErrorHandlerProxy.java:
##########
@@ -51,14 +52,18 @@ public AmbariViewErrorHandlerProxy(ErrorHandler
webAppErrorHandler, AmbariErrorH
@Override
public void handle(String target, Request baseRequest, HttpServletRequest
request, HttpServletResponse response) throws IOException {
-
+ try{
if (isInternalError(request, response)) {
//invoke the ambari error handler
ambariErrorHandler.handle(target, baseRequest, request, response);
} else {
//invoke the original errorhandler
webAppErrorHandler.handle(target, baseRequest, request, response);
}
+ }
+ catch(IOException | ServletException e){
Review Comment:
I thought @brahmareddybattula 's comment was to catch ServletException.
Perhaps also encaupsulate the exception with an IOException and then throw it
out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
