zRains commented on PR #3770: URL: https://github.com/apache/ambari/pull/3770#issuecomment-2114558783
@vanshuhassija Your PR still has some issues, and I'm not sure if they only occur when using **Yarn** separately. Here are some notable problems: 1. **backbone.js** isn't placed in the **vendor** folder. According to the configuration in the brunch file `'javascripts/vendor.js': /^vendor/`, it won't be included in the final build result(vendor.js), leading to the **Uncaught ReferenceError: Backbone is not defined** error still occurring. 2. The issue of **vendor/scripts/bootstrap-popover.js** and **vendor/scripts/bootstrap-tooltip.js** having identical content persists. Is this in reference to [bootstrap-popover](https://getbootstrap.com/docs/5.3/components/popovers/#enable-popovers) and [bootstrap-tooltip](https://getbootstrap.com/docs/5.3/components/tooltips/#enable-tooltips)? 3. There's a misalignment in the UI after running:   You can build and preview it follow the `ambari-web/pom.xml` and serve **public** folder by [vite](https://vitejs.dev/), my **vite.config.js**: ```js import { defineConfig } from 'vite' export default defineConfig({ server: { proxy: { '/api': { target: 'http://Your server addr', changeOrigin: true }, '/api/stomp/v1/websocket': { target: 'ws://Your server addr', changeOrigin: true, ws: true } } } }) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
