JiaLiangC commented on code in PR #3825:
URL: https://github.com/apache/ambari/pull/3825#discussion_r1764277332
##########
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheSizingTest.java:
##########
Review Comment:
The reason for deleting TimelineMetricCacheSizingTest?
##########
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java:
##########
@@ -319,4 +322,24 @@ private long getMillisecondsTime(long time) {
return time;
}
}
+ @Override
+ public void delete(TimelineAppMetricCacheKey key) throws
CacheWritingException {
+ // no need to implement.
+ }
+
+ @Override
+ public Map<TimelineAppMetricCacheKey, TimelineMetricsCacheValue>
loadAll(Iterable<? extends TimelineAppMetricCacheKey> keys) throws
BulkCacheLoadingException, Exception {
+// no need to implement.
+ return null;
+ }
+
+ @Override
+ public void writeAll(Iterable<? extends Map.Entry<? extends
TimelineAppMetricCacheKey, ? extends TimelineMetricsCacheValue>> entries)
throws BulkCacheWritingException, Exception {
+// no need to implement.
+ }
+
+ @Override
+ public void deleteAll(Iterable<? extends TimelineAppMetricCacheKey> keys)
throws BulkCacheWritingException, Exception {
+// no need to implement.
+ }
Review Comment:
If the code here is not specifically implemented, can it be removed？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
