zRains commented on PR #3870: URL: https://github.com/apache/ambari/pull/3870#issuecomment-2463843160
Great changes! This could be the start of a new stage for web updates. I applied your code and tried running it locally, but I encountered a few issues: 1. There's an unnecessary vite.config.js file, and the static asset entry isn't correctly configured in vite.config.ts. 2. tsconfig.node.json file no found. 3. The Bootstrap styles aren't compatible with the current Sass loader, leading to numerous warnings in the console. <img width="1007" alt="image" src="https://github.com/user-attachments/assets/6817cd6c-1880-43e4-8c02-d7d0727acc77";> 4. Some React-related errors appear after launching. <img width="599" alt="image" src="https://github.com/user-attachments/assets/90c605de-ba32-41ae-9b5d-39b9c7234717";> 6. There are missing test cases and service request logic. IMO, these issues might take considerable time to resolve. Additionally, there are still some problems with the previous jQuery upgrade. - [x] #3770 Therefore, I think it would be better to develop this upgrade on a new branch. Thanks for all your hard work, and I hope we can complete this change together:P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
