vanshuhassija commented on code in PR #3941:
URL: https://github.com/apache/ambari/pull/3941#discussion_r1944051139
##########
ambari-web/app/router.js:
##########
@@ -284,15 +284,15 @@ App.Router = Em.Router.extend({
var dfd = $.Deferred();
var self = this;
var auth = App.db.getAuthenticated();
- this.getClusterDataRequest().always(function (xhr) {
+ this.getClusterDataRequest().always(function (xhr, textStatus,
jqXHRorErrorThrown) {
Review Comment:
Or in this case a separate `fail` callback to handle errors would be
appropriate instead of `always`. What do you think @zRains ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
