zRains commented on code in PR #3963:
URL: https://github.com/apache/ambari/pull/3963#discussion_r2011263704
##########
ambari-admin/src/main/resources/ui/ambari-admin/src/layout/SideBar.tsx:
##########
@@ -149,14 +171,25 @@ const SideBar = ({ clusterExists,
isSidebarCollapsed,setIsSidebarCollapsed }: Si
);
})}
</div>
- <div
- className="py-3 d-flex justify-content-center sidebar-collapse
icon-primary"
- style={{ background: "#313d54" }}
- onClick={() => {
- setIsSidebarCollapsed(!isSidebarCollapsed);
- }}
- >
- <FontAwesomeIcon icon={faAngleDoubleRight} />
+ <div className="d-flex flex-column">
+ {onLogout && (
+ <div
+ className="py-2 d-flex justify-content-center sidebar-item"
+ onClick={handleLogout}
+ title="Logout"
+ >
+ <FontAwesomeIcon icon={faSignOutAlt} />
+ </div>
+ )}
+ <div
+ className="py-3 d-flex justify-content-center sidebar-collapse
icon-primary"
+ style={{ background: "#313d54" }}
Review Comment:
I think using bg-[#313d54] would be a better choice. Reducing inline styles
helps with managing and modifying styles more efficiently. Alternatively, you
could define it as a variable in the Tailwind config file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
