rich7420 commented on PR #3981: URL: https://github.com/apache/ambari/pull/3981#issuecomment-2817266092
> 1. According to the WARN it occured : > > ``` > [WARNING] The following patterns were never triggered in this artifact inclusion filter: > o 'commons-collections:commons-collections' > o 'commons-configuration:commons-configuration' > ``` > > So I removed them. > > 2. Though skipping unit test, I built ambari successfully. But the error comes out when I didn't skip test. like this: > > ``` > [ERROR] Errors: > [ERROR] AvoidTransactionalOnPrivateMethodsCheckTest.transactionalOnPrivateMethod:42->AbstractModuleTestSupport.verify:220->AbstractModuleTestSupport.createChecker:118->AbstractModuleTestSupport.createChecker:137 » NoClassDefFound org/apache/commons/collections/FastHashMap > [ERROR] AmbariSwaggerReaderTest.swaggerApiThatIsBothTopLevelAndNestedIsCountedAsTopLevel:172 NullPointer Cannot invoke "java.util.Map.keySet()" because the return value of "io.swagger.models.Swagger.getPaths()" is null > [ERROR] AmbariSwaggerReaderTest.swaggerBasicCase:70 » NoClassDefFound com/sun/jersey/api/core/InjectParam > [ERROR] AmbariSwaggerReaderTest.swaggerConflictingNestedApis:85 » NoClassDefFound com/sun/jersey/api/core/InjectParam > [ERROR] AmbariSwaggerReaderTest.swaggerConflictingNestedApisWithBadPreferredParent:139 » NoClassDefFound com/sun/jersey/api/core/InjectParam > [ERROR] AmbariSwaggerReaderTest.swaggerConflictingNestedApisWithPreferredParent:102 » NoClassDefFound com/sun/jersey/api/core/InjectParam > [ERROR] AmbariSwaggerReaderTest.swaggerConflictingNestedApisWithSamePreferredParent:120 » NoClassDefFound com/sun/jersey/api/core/InjectParam > [ERROR] AmbariSwaggerReaderTest.swaggerNestedApisWithOverwrite:158 NullPointer Cannot invoke "java.util.Map.keySet()" because the return value of "io.swagger.models.Swagger.getPaths()" is null > ``` > > The reason why it comes is we removed commons-collections3.2.2. It seems from`AbstractModuleTestSupport `for `checkstyle package` because `AbstractModuleTestSupport` depends on `FastHashMap`(from commons-collections3.2.2). in https://github.com/apache/ambari/blob/e94d90f5b7f7bee64c87b96508441d954bb94b22/ambari-utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java#L24C1-L25C1 I think the reason is `checkstyle` still depends on FastHashMap. I'll try to change the version of checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
