JiaLiangC commented on PR #4126: URL: https://github.com/apache/ambari/pull/4126#issuecomment-4384311352
Looks good to me. The Python 3 fixes are correct: writing the downloaded cert in binary mode encoding the JSON request body before passing it to urllib.request.Request closing the written certificate file on success Minor non-blocking suggestion: consider using with open(...) in a follow-up for cleaner file handling and to avoid explicit close calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
