Treora opened a new pull request #110: URL: https://github.com/apache/incubator-annotator/pull/110
Addresses issue #109. This makes the functions easier to use for the usual case where the scope is a Node (e.g. the whole document, or `document.body`). Each function internally just casts the scope’s `Node | Range` type to a `Range`, and continues to work with that. Return types are left unchanged, except that the `CssSelector` matcher now returns an `Element`, instead of creating a `Range` that selects that element’s contents. For users that just want to use `CssSelector`s, this would make a lot more sense; and it simplifies our code. As all other functions now accept a Node as their scope, refinement still works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
