+1 +1 for Benjamin's remarks too :)
On Tue, Mar 10, 2020 at 8:39 PM Benjamin Young <byo...@bigbluehat.com> wrote: > > +1 from me--with huge gratitude to Randall for making this all happen!! :D > > The signature and sha's all checked out fine. My local diff (on Windows) has > line ending differences (which I know about...per my git config). My diff > also shows the following files in the git checkout which are not in the > tarball--all of which I think are fine, but wanted to confirm and/or document > for future comparison/checks. > > Files in local git checkout which are not in the tarball include: > - .git/ (as for Randall) > - .nyc_output/ (probably due to a different reporter I used at some point) > - node_modules/ (we don't ship this in the tarball...nor should we afaik) > - packages/fragment-identifier/node_modules/ (same as above) > - packages/fragment-identifier/src/fragment.js (...not sure about this > one...) > > Everything else is identical (ignoring line endings--per platform > differences). > > Any thoughts (or explanations) about the fragment.js situation? > > Otherwise this looks fabulous. Thank you! > Benjamin > > -- > > http://bigbluehat.com/ > > http://linkedin.com/in/benjaminyoung > > ________________________________ > From: Jack Park <jackp...@topicquests.org> > Sent: Tuesday, March 10, 2020 10:23 AM > To: dev@annotator.incubator.apache.org <dev@annotator.incubator.apache.org> > Subject: Re: [VOTE] Release Apache Annotator (incubating) version 0.1.0 > (-rc.2) > > +1 > > On Mon, Mar 9, 2020 at 10:20 PM Randall Leeds <rand...@apache.org> wrote: > > > I'll kick it off. > > > > No differences between tarball and the git tag: > > > > > diff -r apache-annotator-0.1.0-incubating annotator-git > > Only in annotator: .git > > > > Valid checksums: > > > > > sha256sum -c apache-annotator-0.1.0-rc.2-incubating.tar.gz.sha256 > > apache-annotator-0.1.0-rc.2-incubating.tar.gz: OK > > > > > sha512sum -c apache-annotator-0.1.0-rc.2-incubating.tar.gz.sha512 > > apache-annotator-0.1.0-rc.2-incubating.tar.gz: OK > > > > Valid signature (from me): > > > > > gpg --verify apache-annotator-0.1.0-rc.2-incubating.tar.gz.asc > > gpg: assuming signed data in > > 'apache-annotator-0.1.0-rc.2-incubating.tar.gz' > > gpg: Signature made Mon 09 Mar 2020 09:36:50 PM PDT > > gpg: using RSA key > > 83CBD56B79A00C8693C0B919ED6455D90F33F0BB > > gpg: Good signature from "Randall Leeds <rand...@bleeds.info>" > > [ultimate] > > gpg: aka "Randall Leeds <randall.le...@gmail.com>" > > [ultimate] > > gpg: aka "Randall Leeds <rand...@apache.org>" [ultimate] > > > > Running `make check` passes in the apache-annotator-0.1.0-incubating > > directory unpacked from the tarball (Node.js v13.10.1, Yarn v1.22.0). > > > > +1 from me! > > > > On Mon, Mar 9, 2020 at 9:43 PM Randall Leeds <rand...@apache.org> wrote: > > > > > Dear community, > > > > > > I would like to propose we release Apache Annotator (incubating) 0.1.0. > > > > > > This is the second release candidate. The first vote was aborted because > > > it was not made on this list before being brought to the incubator PMC. > > > > > > This is the first release of Apache Annotator and represents a modest but > > > exciting step for the community. We encourage everyone to help us verify > > > that the release is proper and help identify and fix any critical issues > > > with the project's packaging or the proper functioning of the build. > > > > > > The release artifacts are available here: > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/annotator/source/0.1.0/rc.2 > > > > > > There you will find a tarball, a GPG signature, and SHA256/SHA512 > > > checksums. > > > > > > A KEYS file for checking the signatures can be found here: > > > > > > https://dist.apache.org/repos/dist/release/incubator/annotator/KEYS > > > > > > Please verify that the build is from commit > > > 2eb484150c0fa86a144fa3f3f6811e856e761dd6, tagged as v0.1.0-rc.2, by > > > checking out the source tree and comparing it to the contents of the > > > tarball. > > > > > > Please validate the release by checking that the signature and checksums > > > are valid for the uploaded tarball and then unpacking it and ensuring > > that > > > `make && make check` exits cleanly. > > > > > > If you would like to further validate the packaging, the repository is > > set > > > up for Apache Rat to check for proper license headers and notifications. > > As > > > this is our first release, it is important to us that we get these > > > processes correctly in place. > > > > > > If the vote passes, these artifacts will be proposed to Apache Incubator > > > for release as Apache Annotator (incubating) 0.1.0. > > > > > > Regards, > > > Randall Leeds > > > > >
