tilgovi commented on a change in pull request #67: Reorganise webpack-related
files
URL: https://github.com/apache/incubator-annotator/pull/67#discussion_r399738973
##########
File path: web/webpack.config.js
##########
@@ -43,7 +46,7 @@ module.exports = {
],
},
output: {
- filename: '[name].js',
- publicPath: '/',
+ path: path.resolve(__dirname),
Review comment:
Maybe make this `path.resolve(__dirname, 'dist')` and that makes the
gitignore easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
