DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18166>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18166 Concat enhancement ------- Additional Comments From [EMAIL PROTECTED] 2003-03-25 11:50 ------- Peter, I have a couple of issues with your patch. I've reverted parts of your patch that contained removal of comments and the addition of wildcard imports. I'll attach what I have now so that we can go from there. The issues I have: * you completely ignore all <fileset>'s and so on if nested text is present. * encoding is ignored when reading from files. * The handling of header and footer would reintroduce the bug where a newline incorrectly gets appended - I've sort of fixed that by using print instead of println. * I don't think TextElement#setFile should ignore that the referenced file doesn't exist. * The trim attribute in TextElement should apply to nested text as well (instead of unconditionally trimming it. * We might need the sanitizeText logic for header and footer as well. * What do you need trimleading for? * Why do you apply filterchains to nested text but not to header and footer? A long list, I know. And still incomplete, I guess. I'm not sure about the changed semantics of the append attribute, for example.
