antoine 2003/05/25 02:43:53
Modified: src/main/org/apache/tools/ant/types/selectors
DifferentSelector.java
docs/manual/CoreTypes selectors.html
Log:
Make ignoreFileTimes default to true in DifferentSelector to preserve
backward compatibility
in the behavior of the selector and also make the selector more user friendly.
One expects that most users want to ignore file timestamps.
PR: 20205
Submitted by: Jeff Turner (jefft at apache dot org)
Revision Changes Path
1.5 +1 -1
ant/src/main/org/apache/tools/ant/types/selectors/DifferentSelector.java
Index: DifferentSelector.java
===================================================================
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/types/selectors/DifferentSelector.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- DifferentSelector.java 24 May 2003 13:52:49 -0000 1.4
+++ DifferentSelector.java 25 May 2003 09:43:53 -0000 1.5
@@ -81,7 +81,7 @@
private FileUtils fileUtils= FileUtils.newFileUtils();
- private boolean ignoreFileTimes=false;
+ private boolean ignoreFileTimes=true;
/**
1.12 +9 -9 ant/docs/manual/CoreTypes/selectors.html
Index: selectors.html
===================================================================
RCS file: /home/cvs/ant/docs/manual/CoreTypes/selectors.html,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- selectors.html 24 May 2003 13:52:49 -0000 1.11
+++ selectors.html 25 May 2003 09:43:53 -0000 1.12
@@ -271,8 +271,8 @@
<ol>
<li> If there is no 'other' file, it's different.
<li> Files with different lengths are different.
- <li> Files with the same timestamp are the same, unless
<tt>ignoreFileTimes</tt>
- is set. This feature is useful to keep the selection fast.
+ <li> If <tt>ignoreFileTimes</tt> is turned off, then differing file
+ timestamps will cause files to be regarded as different.
<li> Finally a byte-for-byte check is run against the two files
</ol>
@@ -309,18 +309,18 @@
<td valign="top" align="center">Yes</td>
</tr>
<tr>
+ <td valign="top">ignoreFileTimes</td>
+ <td valign="top">Whether to use file times in the comparison or not.
+ Default is true (time differences are ignored).
+ </td>
+ <td valign="top" align="center">No</td>
+ </tr>
+ <tr>
<td valign="top">granularity</td>
<td valign="top">The number of milliseconds leeway to give before
deciding a file is out of date. This is needed because not every
file system supports tracking the last modified time to the
millisecond level. Default is 0 milliseconds, or 2 seconds on DOS
systems.
- </td>
- <td valign="top" align="center">No</td>
- </tr>
- <tr>
- <td valign="top">ignoreFileTimes</td>
- <td valign="top">Whether to use file times in the comparison or not.
- Default is false (time differences are significant).
</td>
<td valign="top" align="center">No</td>
</tr>
