peterreilly 2003/10/15 00:39:35
Modified: src/main/org/apache/tools/ant/taskdefs MacroDef.java
Log:
Opps, compare defaultvalue with name when testing for macrodef equality
fix equality testing
Obtained from: Larry Shatzer
Revision Changes Path
1.10 +12 -9 ant/src/main/org/apache/tools/ant/taskdefs/MacroDef.java
Index: MacroDef.java
===================================================================
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/MacroDef.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- MacroDef.java 23 Sep 2003 14:04:05 -0000 1.9
+++ MacroDef.java 15 Oct 2003 07:39:35 -0000 1.10
@@ -269,15 +269,17 @@
}
Attribute other = (Attribute) obj;
if (name == null) {
- return other.name == null;
- }
- if (!name.equals(other.name)) {
+ if (other.name != null) {
+ return false;
+ }
+ } else if (!name.equals(other.name)) {
return false;
}
if (defaultValue == null) {
- return other.defaultValue == null;
- }
- if (!name.equals(other.defaultValue)) {
+ if (other.defaultValue != null) {
+ return false;
+ }
+ } else if (!defaultValue.equals(other.defaultValue)) {
return false;
}
return true;
@@ -343,9 +345,10 @@
}
TemplateElement other = (TemplateElement) obj;
if (name == null) {
- return other.name == null;
- }
- if (!name.equals(other.name)) {
+ if (other.name != null) {
+ return false;
+ }
+ } else if (!name.equals(other.name)) {
return false;
}
return optional == other.optional;
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
