stevel 2004/10/12 13:52:35 Modified: src/main/org/apache/tools/ant/taskdefs/optional/condition IsPingable.java src/main/org/apache/tools/ant/types defaults.properties Log: ispingable is defined, corrected validation logic (I think :) Revision Changes Path 1.2 +1 -1 ant/src/main/org/apache/tools/ant/taskdefs/optional/condition/IsPingable.java Index: IsPingable.java =================================================================== RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/condition/IsPingable.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- IsPingable.java 8 Oct 2004 08:59:19 -0000 1.1 +++ IsPingable.java 12 Oct 2004 20:52:34 -0000 1.2 @@ -71,7 +71,7 @@ * if an error occurs */ public boolean eval() throws BuildException { - if(host==null && host.length()==0) { + if(host==null || host.length()==0) { throw new BuildException(ERROR_NO_HOSTNAME); } if(timeout<0) { 1.25 +1 -0 ant/src/main/org/apache/tools/ant/types/defaults.properties Index: defaults.properties =================================================================== RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/types/defaults.properties,v retrieving revision 1.24 retrieving revision 1.25 diff -u -r1.24 -r1.25 --- defaults.properties 22 Apr 2004 20:27:21 -0000 1.24 +++ defaults.properties 12 Oct 2004 20:52:34 -0000 1.25 @@ -33,3 +33,4 @@ propertyset=org.apache.tools.ant.types.PropertySet assertions=org.apache.tools.ant.types.Assertions concatfilter=org.apache.tools.ant.filters.ConcatFilter +org.apache.tools.ant.taskdefs.optional.condition.IsPingable \ No newline at end of file
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]