Just some small changes that reduce the whining my IDE does :)
What is the policy w.r.t TLA's in method names?
e.g. getIiopOpts versus getIIOPOpts ?
or setIDLOpts versus setIdlOpts ?
I think the all CAPS accronym is easier to read, but I'm not sure if it breaks the style
Kev
Index: Rmic.java
===================================================================
RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/Rmic.java,v
retrieving revision 1.58
diff -u -r1.58 Rmic.java
--- Rmic.java 22 Nov 2004 09:23:28 -0000 1.58
+++ Rmic.java 3 Dec 2004 10:52:07 -0000
@@ -88,14 +88,14 @@
private File sourceBase;
private String stubVersion;
private Path compileClasspath;
- private Path extdirs;
+ private Path extDirs;
private boolean verify = false;
private boolean filtering = false;
private boolean iiop = false;
- private String iiopopts;
+ private String iiopOpts;
private boolean idl = false;
- private String idlopts;
+ private String idlOpts;
private boolean debug = false;
private boolean includeAntRuntime = true;
private boolean includeJavaRuntime = false;
@@ -121,6 +121,7 @@
/**
* Sets the location to store the compiled files; required
+ * @param base the location to store the compiled files
*/
public void setBase(File base) {
this.baseDir = base;
@@ -128,6 +129,7 @@
/**
* Gets the base directory to output generated class.
+ * @return the location of the compiled files
*/
public File getBase() {
@@ -137,6 +139,7 @@
/**
* Sets the class to run <code>rmic</code> against;
* optional
+ * @param classname the name of the class for rmic to create code for
*/
public void setClassname(String classname) {
this.classname = classname;
@@ -144,6 +147,7 @@
/**
* Gets the class name to compile.
+ * @return the name of the class to compile
*/
public String getClassname() {
return classname;
@@ -151,6 +155,7 @@
/**
* optional directory to save generated source files to.
+ * @param sourceBase the directory to save source files to.
*/
public void setSourceBase(File sourceBase) {
this.sourceBase = sourceBase;
@@ -158,6 +163,7 @@
/**
* Gets the source dirs to find the source java files.
+ * @return sourceBase the directory containing the source files.
*/
public File getSourceBase() {
return sourceBase;
@@ -166,30 +172,40 @@
/**
* Specify the JDK version for the generated stub code.
* Specify "1.1" to pass the "-v1.1" option to
rmic.</td>
+ * @param stubVersion
*/
public void setStubVersion(String stubVersion) {
this.stubVersion = stubVersion;
}
+ /**
+ * Gets the JDK version for the generated stub code.
+ * @return stubVersion
+ */
public String getStubVersion() {
return stubVersion;
}
/**
- * indicates whether token filtering should take place;
- * optional, default=false
+ * Sets token filtering [optional], default=false
+ * @param filter
*/
public void setFiltering(boolean filter) {
- filtering = filter;
+ this.filtering = filter;
}
+ /**
+ * Gets whether token filtering is set
+ * @return filtering
+ */
public boolean getFiltering() {
return filtering;
}
/**
- * generate debug info (passes -g to rmic);
+ * Generate debug info (passes -g to rmic);
* optional, defaults to false
+ * @param debug
*/
public void setDebug(boolean debug) {
this.debug = debug;
@@ -197,6 +213,7 @@
/**
* Gets the debug flag.
+ * @return debug
*/
public boolean getDebug() {
return debug;
@@ -204,6 +221,7 @@
/**
* Set the classpath to be used for this compilation.
+ * @param classpath
*/
public void setClasspath(Path classpath) {
if (compileClasspath == null) {
@@ -215,6 +233,7 @@
/**
* Creates a nested classpath element.
+ * @return classpath
*/
public Path createClasspath() {
if (compileClasspath == null) {
@@ -242,14 +261,18 @@
* Flag to enable verification so that the classes
* found by the directory match are
* checked to see if they implement java.rmi.Remote.
- * Optional; his defaults to false if not set.
+ * optional; This defaults to false if not set.
+ * @param verify
*/
public void setVerify(boolean verify) {
this.verify = verify;
}
- /** Get verify flag. */
+ /**
+ * Get verify flag.
+ * @return verify
+ */
public boolean getVerify() {
return verify;
}
@@ -258,6 +281,7 @@
* Indicates that IIOP compatible stubs should
* be generated; optional, defaults to false
* if not set.
+ * @param iiop
*/
public void setIiop(boolean iiop) {
this.iiop = iiop;
@@ -265,6 +289,7 @@
/**
* Gets iiop flags.
+ * @return iiop
*/
public boolean getIiop() {
return iiop;
@@ -272,16 +297,18 @@
/**
* Set additional arguments for iiop
+ * @iiopopts
*/
- public void setIiopopts(String iiopopts) {
- this.iiopopts = iiopopts;
+ public void setIIOPOpts(String iiopOpts) {
+ this.iiopOpts = iiopOpts;
}
/**
* Gets additional arguments for iiop.
+ * @return iiopOpts
*/
- public String getIiopopts() {
- return iiopopts;
+ public String getIIOPOpts() {
+ return iiopOpts;
}
/**
@@ -303,15 +330,15 @@
/**
* pass additional arguments for idl compile
*/
- public void setIdlopts(String idlopts) {
- this.idlopts = idlopts;
+ public void setIDLopts(String idlOpts) {
+ this.idlOpts = idlOpts;
}
/**
* Gets additional arguments for idl compile.
*/
- public String getIdlopts() {
- return idlopts;
+ public String getIDLOpts() {
+ return idlOpts;
}
/**
@@ -326,15 +353,15 @@
* classpath.
* Optional; default is <code>true</code>.
*/
- public void setIncludeantruntime(boolean include) {
- includeAntRuntime = include;
+ public void setIncludeAntRuntime(boolean include) {
+ this.includeAntRuntime = include;
}
/**
* Gets whether or not the ant classpath is to be included in the
* task's classpath.
*/
- public boolean getIncludeantruntime() {
+ public boolean getIncludeAntRuntime() {
return includeAntRuntime;
}
@@ -344,7 +371,7 @@
* libraries from the executing VM; optional,
* defaults to false
*/
- public void setIncludejavaruntime(boolean include) {
+ public void setIncludeJavaRuntime(boolean include) {
includeJavaRuntime = include;
}
@@ -352,7 +379,7 @@
* Gets whether or not the java runtime should be included in this
* task's classpath.
*/
- public boolean getIncludejavaruntime() {
+ public boolean getIncludeJavaRuntime() {
return includeJavaRuntime;
}
@@ -360,30 +387,30 @@
* Sets the extension directories that will be used during the
* compilation; optional.
*/
- public void setExtdirs(Path extdirs) {
- if (this.extdirs == null) {
- this.extdirs = extdirs;
+ public void setExtDirs(Path extDirs) {
+ if (this.extDirs == null) {
+ this.extDirs = extDirs;
} else {
- this.extdirs.append(extdirs);
+ this.extDirs.append(extDirs);
}
}
/**
- * Maybe creates a nested extdirs element.
+ * Maybe creates a nested extDirs element.
*/
public Path createExtdirs() {
- if (extdirs == null) {
- extdirs = new Path(getProject());
+ if (extDirs == null) {
+ extDirs = new Path(getProject());
}
- return extdirs.createPath();
+ return extDirs.createPath();
}
/**
* Gets the extension directories that will be used during the
* compilation.
*/
- public Path getExtdirs() {
- return extdirs;
+ public Path getExtDirs() {
+ return extDirs;
}
public Vector getCompileList() {
@@ -575,7 +602,7 @@
log("will leave uptodate test to rmic implementation in idl mode.",
Project.MSG_VERBOSE);
} else if (iiop
- && iiopopts != null && iiopopts.indexOf("-always") > -1) {
+ && iiopOpts != null && iiopOpts.indexOf("-always") > -1) {
log("no uptodate test as -always option has been specified",
Project.MSG_VERBOSE);
} else {--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
