> Index: MakeUrl.java
> ===================================================================
> ...
> * @ant.task category="core" name="tourl"
s/tourl/makeurl/ you are using that in the default.properties (not the
SmartFrog name :-)
/**
* error message
*/
public static final String ERROR_MISSING_FILE = "A source file is missing
:";
public static final String ERROR_NO_PROPERTY = "No property defined";
public static final String ERROR_NO_FILES = "No files defined";
A JavaDoc comment only for the first? No [EMAIL PROTECTED] ? <g>
private String filesetsToURL() {
...
log(asUrl, Project.MSG_DEBUG);
Would the output of the origin file be helpful?
log(f + " --> " + asUrl, Project.MSG_DEBUG);
Mmh - same log statement in pathsToURL() ...
public void execute() throws BuildException {
validate();
//now exit here if the property is already set
if (getProject().getProperty(property) != null) {
return;
}
A log statement would be helpful
if (getProject().getProperty(property) != null) {
log("property '" + property + "' already set, exiting <makeurl>",
Project.MSG_VERBOSE);
//same log level as setting the property
return;
}
cheers
Jan
>-----Ursprüngliche Nachricht-----
>Von: Stefan Bodewig [mailto:[EMAIL PROTECTED]
>Gesendet: Dienstag, 23. August 2005 06:06
>An: dev@ant.apache.org
>Betreff: Re: cvs commit:
>ant/src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
>
>On 22 Aug 2005, <[EMAIL PROTECTED]> wrote:
>
>> url = fileToConvert.toURI().toURL().toExternalForm();
>
>I think File.toURI is JDK 1.4+.
>
>What is wrong with FileUtils.toURL()? Shouldn't we improve
>FileUtils and use that from the task if anything is wrong?
>
>Stefan
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED] For
>additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
