Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/31
Haven't done a deep check, but first comments:
- overall it seems to be ok
- get.html: maybe a hint that key and value are trimmed and must not be
null or empty string
- get.html, example: value has doubled equals sign
- get.xml/GetTest.java: method name doesn't match target name
- Get.java: nice to reuse email.Header
- Get.java: trimToNull() could be moved to
org.apache.tools.ant.util.StringUtils
- Get.java:764: the if(isEmpty) is not required
@mbenson: Are you reviewing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
