GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/41
Fix the problem of instanceof test always return true.
This instanceof test will always return true because DataType is the
superclass of variable nested's class ResourceComparator. The variable nested
is not initialized, it would be better to do a null test rather than an
instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/ant master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit 750db910163e364b90346bfa13a6054e470ffd57
Author: Kui LIU <[email protected]>
Date: 2017-10-11T09:54:00Z
Fix the problem of instanceof test always return true.
This instanceof test will always return true because DataType is the
superclass of variable nested's class ResourceComparator. The variable nested
is not initialized, it would be better to do a null test rather than an
instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
