So the one final test that's still failing is this one[1]. It's failing
consistently only on Jenkins, that too with only Java 8 (jdk1.8.0_131).
I have tried reproducing that one locally with that exact Java version
and even the latest Java 8 and haven't been able to reproduce it. Before
I try and debug this on that Jenkins environment (which doesn't seem to
be easy to do), I would like to know if this is reproducible for anyone
else.
[1]
https://builds.apache.org/job/Ant-Build-Matrix-master-Linux/lastCompletedBuild/jdk=JDK%201.8%20(latest)/testReport/org.apache.tools.ant.taskdefs.optional.unix/SymlinkTest/testRecreate/
-Jaikiran
On 10/12/17 3:13 PM, Stefan Bodewig wrote:
On 2017-12-10, Stefan Bodewig wrote:
testCreateDoubleHanging is related to
https://bz.apache.org/bugzilla/show_bug.cgi?id=38199 judging from the
history. Here the link points to a non-existent file and Files.exists
returns false in Java8.
fixed by
@@ -37,6 +37,7 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.PrintStream;
import java.nio.file.Files;
+import java.nio.file.LinkOption;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
@@ -440,7 +441,7 @@ public class Symlink extends DispatchTask {
private void doLink(String res, String lnk) throws BuildException {
final Path link = Paths.get(lnk);
final Path target = Paths.get(res);
- final boolean alreadyExists = Files.exists(link);
+ final boolean alreadyExists = Files.exists(link,
LinkOption.NOFOLLOW_LINKS);
if (!alreadyExists) {
// if the path (at which the link is expected to be created)
isn't already present
// then we just go ahead and attempt to symlink
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
