Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/62#discussion_r167136873
--- Diff:
src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java ---
@@ -91,6 +91,9 @@ protected ResolvedResource
findResourceUsingPatterns(ModuleRevisionId moduleRevi
Set<String> foundRevisions = new HashSet<>();
boolean dynamic =
getSettings().getVersionMatcher().isDynamic(moduleRevision);
for (String pattern : patternList) {
+ if (Thread.currentThread().isInterrupted()) {
+ return null;
--- End diff --
@apupier I originally intended it to be `InterruptedException` but given
that it's a checked exception you would end up changing the method signature of
this method which then causes issues with callers of this API. Hence I
suggested a runtime exception. Returning null could have other (side) effects
than what you intend here - i.e. to abort the execution, so throwing the
exception would be the right thing.
I might have some time tonight, I'll see if this check can be moved to a
better location or handle in a better way.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
