bodewig commented on PR #194: URL: https://github.com/apache/ant/pull/194#issuecomment-1330216852
Good catch, thank you. I could try to turn the byte array into a string, catch the exception and then keep searching for encoded NULs later. But even then it might just fail for some other encoding, something that's even more complex and uses different numbers of bytes per glyph like UTF-8. The more I think about it the more I feel it is impossible to make the code work for general multi-byte encodings, at least without moving the burden to `ZipEncoding` itself. Will need to think about that a bit more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
