jaikiran commented on code in PR #219:
URL: https://github.com/apache/ant/pull/219#discussion_r2134743667
##########
src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java:
##########
@@ -150,6 +154,29 @@ public void setEnableStartTLS(boolean b) {
this.starttls = b;
}
+ /**
+ * Set whether to require authentication to switch to a TLS
+ * connection via STARTTLS.
+ *
+ * @param b boolean; if true STARTTLS will be supported and required.
+ * @since Ant 1.10.16
+ */
+ public void setRequireStartTLS(boolean b) {
+ this.requireStarttls = b;
+ if (b) {
+ setEnableStartTLS(b);
Review Comment:
Setting some other property based on a different property is always tricky.
For example, should we reset "enableStartTLS" to false when this
setRequireStartTLS gets called with "false"? Would that overwrite an explicit
"true" value set through an indepedent call to `setEnableStartTLS()`? I think
we have a similar situation is some other tasks from what I remember. So as
long as we follow that same idea here, I think this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
