[
https://issues.apache.org/jira/browse/ANY23-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386954#comment-14386954
]
ASF GitHub Bot commented on ANY23-247:
--------------------------------------
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/17
ANY23-247 FIX Attribute name itemscope associated with an element type html
must be followed by the ' = ' character.
Hi Folks,
PR which fixes this issue locally. I am getting clean builds now again
after introducing this new MissingItemscopeAttributeValueRule class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/any23 ANY23-247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 5ac2307a0245f06f07cbdbe300bc8608f73b1ba1
Author: Lewis John McGibbney <[email protected]>
Date: 2015-03-30T16:43:25Z
ANY23-247 FIX Attribute name itemscope associated with an element type html
must be followed by the ' = ' character.
----
> FIX Attribute name "itemscope" associated with an element type "html" must be
> followed by the ' = ' character.
> --------------------------------------------------------------------------------------------------------------
>
> Key: ANY23-247
> URL: https://issues.apache.org/jira/browse/ANY23-247
> Project: Apache Any23
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Fix For: 1.3
>
>
> In the following markup
> {code}
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
> "http://www.w3.org/TR/html4/loose.dtd";>
> <html xmlns="http://www.w3.org/1999/xhtml";
> xmlns:og="http://opengraphprotocol.org/schema/";
> xmlns:fb="http://www.facebook.com/2008/fbml"; version="HTML+RDFa 1.0"
> xml:lang="en" itemscope itemtype="http://schema.org/Product";>
> <head>
> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
> <meta http-equiv="X-UA-Compatible" content="IE=edge" />
> <meta name="generator" content="ToolTwist" />
> ...
> {code}
> Due to the absence of any subsequent value for *itemscope*, we get the
> following error in our web server logs
> {code}
> [Fatal Error] :2:185: Attribute name "itemscope" associated with an element
> type "html" must be followed by the ' = ' character.
> {code}
> Although the markup semantics are incorrect, Any23 should simply perform a
> check for the itemscope value being null, if this is the case then add *=""*,
> there is a precedent for us doing something like this before, I just cant
> find the ticket right now!
> The code we need to add is present within either
> core/src/main/java/org/apache/any23/extractor/microdata/ItemScope.java
> core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
