[
https://issues.apache.org/jira/browse/ANY23-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357970#comment-16357970
]
ASF GitHub Bot commented on ANY23-264:
--------------------------------------
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/63
ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT
I upgraded the commons-csv dependency from `1.0-SNAPSHOT-rev1148315` to
`1.5`.
On running `mvn clean install`, all tests pass.
A couple of minor code changes I made along the way:
1. Deleted dead code in `if (delimiter.length() != 1 ||
delimiter.equals(""))`
2. Added a null-check in `CSVExtractor.processHeader()`
3. Deleted `NULL_CHAR = ' '` from `CSVReaderBuilder`. Not sure why that was
being used as a comment marker--guessing it was meant to disable comments
during strategy testing, which the default `CSVFormat` does already.
4. Deleted non-standard use of the character `'` for encapsulation. Not
sure why that was being used as such. Both `CSVFormat.DEFAULT` and the defunct
`CSVStrategy.DEFAULT_STRATEGY`, as well as the RFC 4180 standard use `"` as the
encapsulation character.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-264
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit 7a7db20069da63bb1312dd12820c2f2ca301856f
Author: Hans <firedrake93@...>
Date: 2018-02-09T05:27:30Z
ANY23-264 Upgrade to use public commons-csv instead of custom SNAPSHOT
----
> Upgrade to use public commons-csv instead of custom SNAPSHOT
> ------------------------------------------------------------
>
> Key: ANY23-264
> URL: https://issues.apache.org/jira/browse/ANY23-264
> Project: Apache Any23
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Lewis John McGibbney
> Assignee: Hans Brende
> Priority: Major
> Fix For: 2.3
>
>
> Unbeknown to me, it appears that commons-csv finally released a couple of
> artifacts which means we can drop support of our [old SNAPSHOT dependency and
> makeshift
> repository|http://svn.apache.org/repos/asf/any23/repo-ext/org/apache/commons/commons-csv/]
> in favor of a nice new shiny public artifact
> http://search.maven.org/#artifactdetails|org.apache.commons|commons-csv|1.1|jar
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
