[
https://issues.apache.org/jira/browse/ANY23-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382823#comment-16382823
]
Lewis John McGibbney commented on ANY23-332:
--------------------------------------------
+1, this was neglected when we 1) shifted the OpenIE stuff out of core to a
separate module, and then 2) forgotten when we changed the module to a plugin
very recently. Excellent catch.
> Plugin-specific properties shouldn't be declared in
> default-configuration.properties?
> -------------------------------------------------------------------------------------
>
> Key: ANY23-332
> URL: https://issues.apache.org/jira/browse/ANY23-332
> Project: Apache Any23
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Hans Brende
> Priority: Minor
> Fix For: 2.3
>
>
> I noticed that one of the properties in the
> {{default-configuration.properties}} file is called
> "{{any23.extraction.openie.confidence.threshold}}".
> However, given that OpenIE is a dynamically-loaded plugin (not part of the
> core module), it doesn't make sense to me to have OpenIE-specific properties
> declared in the default-configuration file in the *api* module (it also shows
> up in IntelliJ as being the only "unused" property in the config file).
> It might make more sense to have a separate OpenIE-specific configuration
> file declared in the OpenIE plugin jar, and then that file would be appended
> to the api default-configuration file when doing OpenIE stuff.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
