On Wed, 5 Jan 2022 at 09:41, Peter Ansell <[email protected]> wrote: > > On Wed, 5 Jan 2022 at 07:57, lewis john mcgibbney <[email protected]> wrote: > > > > Thanks > > > > On Tue, Jan 4, 2022 at 9:49 AM Hans Brende <[email protected]> wrote: > > > > > +1 from me! > > > > > > - Hans > > > > > > > > > On Tue, Jan 4, 2022 at 5:19 PM lewis john mcgibbney <[email protected]> > > > wrote: > > > > > >> Hi Any23 PMC, > > >> > > >> Please VOTE on the 2nd release candidate for Apache Any23 2.6. Most > > >> notably this RC addresses several security vulnerabilities by upgrading > > >> every single Any23 dependency. We were unfortunately unable to get enough > > >> PMC VOTE's for the 1st RC so I dropped it. It would be greatly > > >> appreciated > > >> if you could take a small amount of time to review this RC. > > >> > > >> We solved 62 issues: > > >> https://issues.apache.org/jira/projects/ANY23/versions/12350556 > > >> > > >> Git source tag (7ea496991f3a053b00cba2ec82ef8a8a4d7e401e): > > >> > > >> https://gitbox.apache.org/repos/asf?p=any23.git;a=tag;h=refs/tags/any23-2.6 > > >> > > >> Staging repo: > > >> https://repository.apache.org/content/repositories/orgapacheany23-1011 > > >> > > >> Staging source and binaries: > > >> https://dist.apache.org/repos/dist/dev/any23/2.6/ > > >> > > >> PGP release keys (signed using 48BAEBF6): > > >> https://dist.apache.org/repos/dist/release/any23/KEYS > > >> > > >> Vote will be open for 72 hours. > > >> > > >> [ ] +1, release as Any23 2.6 > > >> [ ] +/-0, fine, but consider to fix few issues before... > > >> [ ] -1, nope, because... (and please explain why) > > >> > > >> P.S. Here is my +1 > > >> > > Hi Lewis, > > It is failing to build using Java-8 for me due to the following > exception when running the formatter-maven-plugin: > > [ERROR] Failed to execute goal > net.revelc.code.formatter:formatter-maven-plugin:2.17.1:format > (default) on project apache-any23: Execution default of goal > net.revelc.code.formatter:formatter-maven-plugin:2.17.1:format failed: > Unable to load the mojo 'format' in the plugin > 'net.revelc.code.formatter:formatter-maven-plugin:2.17.1' due to an > API incompatibility: > org.codehaus.plexus.component.repository.exception.ComponentLookupException: > net/revelc/code/formatter/FormatterMojo has been compiled by a more > recent version of the Java Runtime (class file version 55.0), this > version of the Java Runtime only recognizes class file versions up to > 52.0 > [ERROR] ----------------------------------------------------- > [ERROR] realm = > plugin>net.revelc.code.formatter:formatter-maven-plugin:2.17.1 > [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy > [ERROR] urls[0] = > file:/home/ubuntu/.m2/repository/net/revelc/code/formatter/formatter-maven-plugin/2.17.1/formatter-maven-plugin-2.17.1.jar > [ERROR] urls[1] = > file:/home/ubuntu/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.13.0/jackson-annotations-2.13.0.jar > [ERROR] urls[2] = > file:/home/ubuntu/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.13.0/jackson-core-2.13.0.jar > [ERROR] urls[3] = > file:/home/ubuntu/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.13.0/jackson-databind-2.13.0.jar > [ERROR] urls[4] = > file:/home/ubuntu/.m2/repository/com/google/guava/guava/31.0.1-jre/guava-31.0.1-jre.jar > [ERROR] urls[5] = > file:/home/ubuntu/.m2/repository/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar > [ERROR] urls[6] = > file:/home/ubuntu/.m2/repository/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar > [ERROR] urls[7] = > file:/home/ubuntu/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar > [ERROR] urls[8] = > file:/home/ubuntu/.m2/repository/org/checkerframework/checker-qual/3.12.0/checker-qual-3.12.0.jar > [ERROR] urls[9] = > file:/home/ubuntu/.m2/repository/com/google/errorprone/error_prone_annotations/2.7.1/error_prone_annotations-2.7.1.jar > [ERROR] urls[10] = > file:/home/ubuntu/.m2/repository/com/google/j2objc/j2objc-annotations/1.3/j2objc-annotations-1.3.jar > [ERROR] urls[11] = > file:/home/ubuntu/.m2/repository/commons-beanutils/commons-beanutils/1.9.4/commons-beanutils-1.9.4.jar > [ERROR] urls[12] = > file:/home/ubuntu/.m2/repository/commons-logging/commons-logging/1.2/commons-logging-1.2.jar > [ERROR] urls[13] = > file:/home/ubuntu/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar > [ERROR] urls[14] = > file:/home/ubuntu/.m2/repository/net/revelc/code/formatter/jsdt-core/3.0.0/jsdt-core-3.0.0.jar > [ERROR] urls[15] = > file:/home/ubuntu/.m2/repository/net/revelc/code/formatter/xml-formatter/0.2.2/xml-formatter-0.2.2.jar > [ERROR] urls[16] = > file:/home/ubuntu/.m2/repository/net/sourceforge/cssparser/cssparser/0.9.29/cssparser-0.9.29.jar > [ERROR] urls[17] = > file:/home/ubuntu/.m2/repository/org/apache/commons/commons-digester3/3.2/commons-digester3-3.2.jar > [ERROR] urls[18] = > file:/home/ubuntu/.m2/repository/cglib/cglib/2.2.2/cglib-2.2.2.jar > [ERROR] urls[19] = > file:/home/ubuntu/.m2/repository/asm/asm/3.3.1/asm-3.3.1.jar > [ERROR] urls[20] = > file:/home/ubuntu/.m2/repository/org/codehaus/plexus/plexus-resources/1.2.0/plexus-resources-1.2.0.jar > [ERROR] urls[21] = > file:/home/ubuntu/.m2/repository/org/codehaus/plexus/plexus-utils/3.4.1/plexus-utils-3.4.1.jar > [ERROR] urls[22] = > file:/home/ubuntu/.m2/repository/org/eclipse/jdt/org.eclipse.jdt.core/3.27.0/org.eclipse.jdt.core-3.27.0.jar > [ERROR] urls[23] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.core.resources/3.15.100/org.eclipse.core.resources-3.15.100.jar > [ERROR] urls[24] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.core.expressions/3.8.0/org.eclipse.core.expressions-3.8.0.jar > [ERROR] urls[25] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.core.runtime/3.23.0/org.eclipse.core.runtime-3.23.0.jar > [ERROR] urls[26] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.osgi/3.17.0/org.eclipse.osgi-3.17.0.jar > [ERROR] urls[27] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.equinox.common/3.15.0/org.eclipse.equinox.common-3.15.0.jar > [ERROR] urls[28] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.core.jobs/3.12.0/org.eclipse.core.jobs-3.12.0.jar > [ERROR] urls[29] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.equinox.registry/3.11.0/org.eclipse.equinox.registry-3.11.0.jar > [ERROR] urls[30] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.equinox.preferences/3.9.0/org.eclipse.equinox.preferences-3.9.0.jar > [ERROR] urls[31] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.core.contenttype/3.8.0/org.eclipse.core.contenttype-3.8.0.jar > [ERROR] urls[32] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.equinox.app/1.6.0/org.eclipse.equinox.app-1.6.0.jar > [ERROR] urls[33] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.core.filesystem/1.9.100/org.eclipse.core.filesystem-1.9.100.jar > [ERROR] urls[34] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.text/3.12.0/org.eclipse.text-3.12.0.jar > [ERROR] urls[35] = > file:/home/ubuntu/.m2/repository/org/eclipse/platform/org.eclipse.core.commands/3.10.100/org.eclipse.core.commands-3.10.100.jar > [ERROR] urls[36] = > file:/home/ubuntu/.m2/repository/org/jsoup/jsoup/1.13.1/jsoup-1.13.1.jar > [ERROR] urls[37] = > file:/home/ubuntu/.m2/repository/org/w3c/css/sac/1.3/sac-1.3.jar > [ERROR] Number of foreign imports: 1 > [ERROR] import: Entry[import from realm ClassRealm[maven.api, parent: null]] > [ERROR] > [ERROR] ----------------------------------------------------- > [ERROR] > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with > the -e switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException > > I have no opinions about the Java versions myself. If the Java-11 > build JDK requirement is documented and the list of supported runtime > JRE versions are documented then it would be useful. > > The requirement to use Java-11 as the build JDK is currently > documented for the formatter-maven-plugin: > > https://code.revelc.net/formatter-maven-plugin/plugin-info.html#system-requirements > > Trying again to build with Java-11 on an Ubuntu running on Windows > Subsystem for Linux 2 fails in the Encoding Detection module with the > following exception, indicating that it may be presuming a default > encoding somewhere and building on Windows returns a different default > encoding to Linux: > > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] TikaEncodingDetectorTest.testISO8859HTML:58->assertEncoding:128 > Unexpected encoding expected:<[ISO-8859-1]> but was:<[windows-1252]> > [ERROR] TikaEncodingDetectorTest.testISO8859XHTML:63->assertEncoding:128 > Unexpected encoding expected:<[ISO-8859-1]> but was:<[windows-1252]> > [INFO] > [ERROR] Tests run: 12, Failures: 2, Errors: 0, Skipped: 0 > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary for Apache Any23 2.6: > [INFO] > [INFO] Apache Any23 ....................................... SUCCESS [01:57 > min] > [INFO] Apache Any23 :: Base API ........................... SUCCESS [ 56.016 > s] > [INFO] Apache Any23 :: Test Resources ..................... SUCCESS [ 1.068 > s] > [INFO] Apache Any23 :: CSV Utilities ...................... SUCCESS [ 2.759 > s] > [INFO] Apache Any23 :: Mime Type Detection ................ SUCCESS [01:10 > min] > [INFO] Apache Any23 :: Encoding Detection ................. FAILURE [ 4.160 > s] > [INFO] Apache Any23 :: Core ............................... SKIPPED > [INFO] Apache Any23 :: CLI ................................ SKIPPED > [INFO] > ------------------------------------------------------------------------
Tracing the error in a debugger shows that the correct result, "ISO-8859-1" is found by the meta tag detection method, but it is then overridden with "windows-1252" because a carriage return character is detected by the following code because Git on WSL2 is checking the code out using Windows line-endings: https://github.com/apache/any23/blob/any23-2.6/encoding/src/main/java/org/apache/any23/encoding/EncodingUtils.java#L62-L69 Peter
