[ 
https://issues.apache.org/jira/browse/APEXCORE-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302226#comment-15302226
 ] 

ASF GitHub Bot commented on APEXCORE-146:
-----------------------------------------

GitHub user ilganeli opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/344

    [APEXCORE-146] Add ClonePartitioner

    * Created a Clone partitioner similar to the StatelessPartitioner that 
assigns all data to all partitions
    * Added a simple unit test suite to test scale up and scale down
    
    **Questions**
    Is there a good place/way to add a test to verify that data is partitioned 
appropriately? For example, the stateless partitioner assigns keys based on the 
nearest power of two - is that validated anywhere?
    
    How is the serialVersionUUID generated?
    
    Does the manual assignment of ports to PartitionKeys need to happen for 
each Partition? There is a comment in the Partition class that by default all 
data is sent to all partitions. However, digging into the implementation in 
depth doesn't show that behavior. Instead, it seems data is assigned based on 
the mask associated with each Partition. 
    
    This references: https://issues.apache.org/jira/browse/APEXCORE-146

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilganeli/incubator-apex-core APEXCORE-146

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #344
    
----
commit e2f50274ccf4e3d1cc515d9770ee9e46a0e2e57b
Author: Ilya Ganelin <ilya.gane...@capitalone.com>
Date:   2016-05-25T16:59:55Z

    Started updates on clone partitioner.

commit 92c1eb31521deff1e9314751cf41892e3ed6793c
Author: Ilya Ganelin <ilya.gane...@capitalone.com>
Date:   2016-05-26T15:13:58Z

    Added a new partitioner that replicates data across all partitions by 
default.

----


> Add A Clone Partitioner Which Sends The Same Data To Each Partition
> -------------------------------------------------------------------
>
>                 Key: APEXCORE-146
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-146
>             Project: Apache Apex Core
>          Issue Type: New Feature
>            Reporter: Timothy Farkas
>            Assignee: Ilya Ganelin
>
> This should go into com.datatorrent.common.partitioner and would be very 
> similar to the StatelessPartitioner



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to