[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314788#comment-15314788
 ] 

ASF GitHub Bot commented on APEXMALHAR-2104:
--------------------------------------------

Github user PramodSSImmaneni commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/304#discussion_r65773905
  
    --- Diff: 
library/src/main/java/org/apache/apex/malhar/lib/fs/GenericFileOutputOperator.java
 ---
    @@ -39,8 +41,8 @@
      *
      * @since 3.4.0
      */
    -
    -public class BytesFileOutputOperator extends 
AbstractSingleFileOutputOperator<byte[]>
    +@org.apache.hadoop.classification.InterfaceStability.Evolving
    +public abstract class GenericFileOutputOperator<INPUT> extends 
AbstractSingleFileOutputOperator<INPUT>
    --- End diff --
    
    Why abstract?


> BytesFileOutputOperator Refactoring
> -----------------------------------
>
>                 Key: APEXMALHAR-2104
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2104
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Yogi Devendra
>            Assignee: Yogi Devendra
>            Priority: Minor
>             Fix For: 3.5.0
>
>
> BytesFileOutputOperator has two ports one is for byte[] input other is for 
> String input. 
> We should allow app developers to connect to any one of this port. 
> Thus, both the streams should be marked as optional.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to