[
https://issues.apache.org/jira/browse/APEXCORE-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319687#comment-15319687
]
ASF GitHub Bot commented on APEXCORE-470:
-----------------------------------------
GitHub user sandeshh opened a pull request:
https://github.com/apache/apex-core/pull/349
APEXCORE-470
1. Added the new API - setOperatorAttribute
2. updated the unit tests,
3. marked "setAttribute(Operator..." as deprecated
@PramodSSImmaneni please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandeshh/apex-core APEXCORE-470
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-core/pull/349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #349
----
commit bcd3426ba65f5291925dedb1e4fdfef4c80096ed
Author: sandeshh <[email protected]>
Date: 2016-06-07T23:27:26Z
APEXCORE-470 - Added the new api setOperatorAttribute and updated the
tests, also marked setAttribute(Operator... as deprecated
----
> New Api for setting the attribute on the operator ( setOperatorAttribute )
> --------------------------------------------------------------------------
>
> Key: APEXCORE-470
> URL: https://issues.apache.org/jira/browse/APEXCORE-470
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Sandesh
> Assignee: Sandesh
>
> Currently, *setAttribute* is used to set the operator attributes. Other 2
> Attribute setting APIs are specific to input ports (*setInputPortAttributes*)
> and output ports (*setOutputPortsAttributes*).
> Proposal is to have *SetOperatorAttribute* api, which will clearly indicate
> that user wants set attributes on the operator.
> ( setOperatorAttribute(Operator operator, Attribute<T> key, T value) )
> Following will be the roles for the APIs
> *setAttributes* --> for setting Attributes for the whole DAG (
> setAttribute(Operator operator, Attribute<T> key, T value) - can be
> deprecated )
> *setOperatorAttributes* --> for setting Attributes for the operator
> All the unit test cases using the previous API will be renamed as a part of
> this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
