Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/319#discussion_r69658261
--- Diff:
library/src/test/java/org/apache/apex/malhar/lib/window/SumAccumulation.java ---
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.apex.malhar.lib.window;
+
+/**
+ * Accumulation that does a simple sum of longs
+ */
+public class SumAccumulation implements Accumulation<Long, Long, Long>
+{
+ @Override
+ public Long defaultAccumulatedValue()
+ {
+ return 0L;
+ }
+
+ @Override
+ public Long accumulate(Long accumulatedValue, Long input)
+ {
+ return accumulatedValue + input;
--- End diff --
This is an example of the interface promoting an implementation that is
subject to boxing and GC. It will be much more efficient to accumulate values
in an internal long member variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
