Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/347#discussion_r72343723
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -355,10 +366,13 @@ public void createConnection() throws JMSException
*/
protected ConnectionFactory getConnectionFactory()
{
- logger.debug("class {} properties {}", connectionFactoryClass,
connectionFactoryProperties);
+ logger.debug("connectionFactoryBuilder {} connectionFactoryClass {}
properties {}", "" + connectionFactoryBuilder,
+ connectionFactoryClass, connectionFactoryProperties);
ConnectionFactory cf;
try {
- if (connectionFactoryClass != null) {
+ if (connectionFactoryBuilder != null) {
+ cf = connectionFactoryBuilder.buildConnectionFactory();
+ } else if (connectionFactoryClass != null) {
--- End diff --
Also shouldn't the connection factory properties be actually handled by the
builder?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
