[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399109#comment-15399109
 ] 

ASF GitHub Bot commented on APEXMALHAR-2172:
--------------------------------------------

GitHub user DT-Priyanka opened a pull request:

    https://github.com/apache/apex-malhar/pull/358

    [review only]APEXMALHAR-2172: Updates to JDBC Poll Input Operator

    Changes include:
    1. Using jooq query to construct sql queries
    2. Update logic to query based on row numbers instead of primary key column 
values
    3. Small fixes
    4. Code refactoring to make it more readable
    5. Update operator to emit pojo class constructed from table input fields
    6. Update to test cases, to abstract out generic test code and add more 
tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DT-Priyanka/incubator-apex-malhar 
APEXMALHAR-2172-jdbc-poller-input

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #358
    
----
commit 64cfd4767c2411ffbc87f5d87d413c888c935bad
Author: Priyanka Gugale <[email protected]>
Date:   2016-07-19T06:40:08Z

    APEXMALHAR-2172: Updates to JDBC Poll Input Operator

----


> Update JDBC poll input operator to fix issues
> ---------------------------------------------
>
>                 Key: APEXMALHAR-2172
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2172
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>
> Update JDBCPollInputOperator to:
> 1. Fix small bugs
> 2. Use jooq query dsl library to construct sql queries
> 3. Make code more readable
> 4. Use row counts rather than key column values to partition reads



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to