[
https://issues.apache.org/jira/browse/APEXMALHAR-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402456#comment-15402456
]
ASF GitHub Bot commented on APEXMALHAR-2156:
--------------------------------------------
Github user sanjaypujare commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/347#discussion_r73017855
--- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
@@ -76,18 +76,52 @@
private transient Session session;
private transient Destination destination;
- private String connectionFactoryClass;
- private Map<String, String> connectionFactoryProperties =
Maps.newHashMap();
+ private ConnectionFactoryBuilder connectionFactoryBuilder = new
DefaultConnectionFactoryBuilder();
private String ackMode = "CLIENT_ACKNOWLEDGE";
- private String clientId = "TestClient";
- private String subject = "TEST.FOO";
+ private String clientId;
+ private String subject;
private int batch = 10;
private int messageSize = 255;
private boolean durable = false;
private boolean topic = false;
private boolean verbose = false;
protected boolean transacted = true;
+ public abstract static class ConnectionFactoryBuilder
+ {
+ protected Map<String, String> connectionFactoryProperties =
Maps.newHashMap();
+
+ public Map<String, String> getConnectionFactoryProperties()
+ {
+ return connectionFactoryProperties;
+ }
+
+ public void setConnectionFactoryProperties(Map<String, String>
connectionFactoryProperties)
+ {
+ this.connectionFactoryProperties = connectionFactoryProperties;
+ }
+
+ public abstract ConnectionFactory buildConnectionFactory();
+ }
+
+ public static class DefaultConnectionFactoryBuilder extends
ConnectionFactoryBuilder
+ {
+
+ @Override
+ public ConnectionFactory buildConnectionFactory()
+ {
+ ConnectionFactory cf;
+ try {
--- End diff --
With the new scheme of using a ConnectionFactoryBuilder we don't need it
(as we discussed it last). So the caller can just provide a custom builder with
his own connectionFactoryClass in that builder.
> JMS Input operator enhancements
> -------------------------------
>
> Key: APEXMALHAR-2156
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2156
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Sanjay M Pujare
> Assignee: Sanjay M Pujare
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> This is described in
> https://drive.google.com/open?id=1gapzjxTiePP0VwaOrc-FWfw4xNK6bcIuxkNkGKoZAiA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
