Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/364#discussion_r73431751
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/OperatorContext.java ---
@@ -84,12 +87,13 @@ public void setIdleTimeout(long idleTimeout)
* @param attributes the value of attributes
* @param parentContext
*/
- public OperatorContext(int id, AttributeMap attributes, Context
parentContext)
+ public OperatorContext(int id, String operatorName, AttributeMap
attributes, Context parentContext)
{
super(attributes, parentContext);
this.lastProcessedWindowId = Stateless.WINDOW_ID;
this.id = id;
this.stateless = super.getValue(OperatorContext.STATELESS);
+ this.operatorName = Preconditions.checkNotNull(operatorName, "operator
name");
--- End diff --
I tried to call `LogicalPlan.addOperator(null, GenericTestOperator.class)`
in LogicalPlanTest and no exception was raised until `LogicalPlan.validate()`
was called. IMO, both `null` and empty string should be disallowed in the
addOperator() itself and OperatorContext should not do additional checks. For
example, OperatorMeta does not do such checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
