[
https://issues.apache.org/jira/browse/APEXCORE-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406715#comment-15406715
]
ASF GitHub Bot commented on APEXCORE-448:
-----------------------------------------
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/364#discussion_r73431751
--- Diff:
engine/src/main/java/com/datatorrent/stram/engine/OperatorContext.java ---
@@ -84,12 +87,13 @@ public void setIdleTimeout(long idleTimeout)
* @param attributes the value of attributes
* @param parentContext
*/
- public OperatorContext(int id, AttributeMap attributes, Context
parentContext)
+ public OperatorContext(int id, String operatorName, AttributeMap
attributes, Context parentContext)
{
super(attributes, parentContext);
this.lastProcessedWindowId = Stateless.WINDOW_ID;
this.id = id;
this.stateless = super.getValue(OperatorContext.STATELESS);
+ this.operatorName = Preconditions.checkNotNull(operatorName, "operator
name");
--- End diff --
I tried to call `LogicalPlan.addOperator(null, GenericTestOperator.class)`
in LogicalPlanTest and no exception was raised until `LogicalPlan.validate()`
was called. IMO, both `null` and empty string should be disallowed in the
addOperator() itself and OperatorContext should not do additional checks. For
example, OperatorMeta does not do such checks.
> Make operator name available in OperatorContext
> -----------------------------------------------
>
> Key: APEXCORE-448
> URL: https://issues.apache.org/jira/browse/APEXCORE-448
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> Need name of the logical operator in the OperatorContext which can be used by
> WindowDataManager to create a unique path per logical operator .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
