Hello Community,

I would like to take up this JIRA issue
https://issues.apache.org/jira/browse/APEXMALHAR-2151

In the current implementation, FSLoader loads the data from a file but the
data needs to be in JSON format.
Support for reading from different formats would be a good addition.

To be able to easily plug in support for different formats, I propose
following design changes :
1. Make FSLoader
<https://github.com/apache/apex-malhar/blob/master/contrib/src/main/java/com/datatorrent/contrib/enrich/FSLoader.java>
abstract
2. Add an abstract method extractFields(String line) which gets called from
loadInitialData()
<https://github.com/apache/apex-malhar/blob/master/contrib/src/main/java/com/datatorrent/contrib/enrich/FSLoader.java#L94>
3. Concrete implementations of FSLoader will provide an implementation of
extractFields(String line) to parse the line, extract fields and return
them as a Map. For e.g JSONFSLoader, DelimitedFSLoader, FixedLengthFSLoader

To start with, I will provide implementations of JSONFSLoader,
DelimitedFSLoader.

Would like to receive  feedback on proposed design changes.

 Thanks,
Shubham

Reply via email to