[
https://issues.apache.org/jira/browse/APEXCORE-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408312#comment-15408312
]
ASF GitHub Bot commented on APEXCORE-495:
-----------------------------------------
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/360#discussion_r73581539
--- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java
---
@@ -180,4 +188,40 @@ public void
testLaunchAppPackagePrecedenceWithConfigPackage() throws Exception
Assert.assertEquals("app-default", props.get("dt.test.5"));
Assert.assertEquals("package-default", props.get("dt.test.6"));
}
+
+ @Test
+ public void testAppFromOnlyConfigPackage() throws Exception
+ {
+ ApexCli.LaunchCommandLineInfo commandLineInfo =
+ ApexCli.getLaunchCommandLineInfo(new String[]{"-conf",
configFile.getAbsolutePath(), appFile.getAbsolutePath(), "-useConfigApps",
"exclusive"});
+
+ ApexCli apexCli = new ApexCli();
+ apexCli.init();
+
+ Assert.assertEquals("configApps", "exclusive",
commandLineInfo.useConfigApps);
+
+ apexCli.getLaunchAppPackageArgs(ap, cp, commandLineInfo, new
ConsoleReader());
+
+ Assert.assertEquals(ap.getApplications().size(), 1);
+ }
+
+ @Test
+ public void testMergeAppFromConfigAndAppPackage() throws Exception
+ {
+ ApexCli.LaunchCommandLineInfo commandLineInfo =
+ ApexCli.getLaunchCommandLineInfo(new String[]{"-conf",
configFile.getAbsolutePath(), appFile.getAbsolutePath(), "-useConfigApps",
"inclusive"});
+
+ Assert.assertEquals("configApps", "inclusive",
commandLineInfo.useConfigApps);
+
+ ApexCli apexCli = new ApexCli();
+ apexCli.init();
+
+ try {
+ apexCli.getLaunchAppPackageArgs(ap, cp, commandLineInfo, new
ConsoleReader());
+ } catch (Throwable throwable ) {
--- End diff --
why are we catching throwable instead of the exception you expect it to
throw? Also, there is an extra space before the closing paren.
> Enhancing the configuration package to store apps
> -------------------------------------------------
>
> Key: APEXCORE-495
> URL: https://issues.apache.org/jira/browse/APEXCORE-495
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Sandesh
> Assignee: Sandesh
>
> Apex supports configuration package, separates application package from the
> actual configuration. (http://docs.datatorrent.com/configuration_packages/)
> We want to enhance the configuration package by adding support to "add Apps"
> (json format).
> UseCase: Multiple users sharing the same app package, but have a different
> view of the golden copy of the app package.
> Note: This feature is requested by an Apex user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
