[ 
https://issues.apache.org/jira/browse/APEXCORE-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415147#comment-15415147
 ] 

ASF GitHub Bot commented on APEXCORE-496:
-----------------------------------------

Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/361#discussion_r74229007
  
    --- Diff: api/src/main/java/com/datatorrent/api/StatsListener.java ---
    @@ -115,6 +115,28 @@
         List<OperatorResponse> getOperatorResponse();
       }
     
    +  /**
    +   * An interface to the DAG. Stats listener can get information about
    +   * operator or other elements in the DAG through this interface. 
currerntly
    +   * we only provide method to extract the operator name based on the 
physical
    +   * id of the operator. In future more methods can be added.
    +   *
    +   */
    --- End diff --
    
    exposing all information may expose internal implementation of the DAG. we 
can only have dependency on apex-api. Can you suggest which information can be 
provided to stat listener without adding dependency on the apex-engine. I can 
think of following
    - name
    - number of partitions for self.
    - aggregated stats at logical operator level.
    This list could be expanded in future.
    
    This jira puts the required infrastructure without breaking backward 
compatibility.


> Provide Operator name to StatsListener
> --------------------------------------
>
>                 Key: APEXCORE-496
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-496
>             Project: Apache Apex Core
>          Issue Type: Task
>            Reporter: Tushar Gosavi
>            Assignee: Tushar Gosavi
>
> In case of shared statslistener it becomes difficult to identify for which 
> operator
> s stats are being processed. we could provide operator name in 
> BatchedOperatorStats to easily identify the operator. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to