[
https://issues.apache.org/jira/browse/APEXMALHAR-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971475#comment-15971475
]
ASF GitHub Bot commented on APEXMALHAR-2473:
--------------------------------------------
GitHub user oliverwnk opened a pull request:
https://github.com/apache/apex-malhar/pull/605
APEXMALHAR-2473 Support for global cache meta information in db Cache…
…Manager
1. Uses Component interface and newly implemented CacheContext to pass
properties to the Stores by calling setup(CacheContext).
2. APEXMALHAR-2474: FSLoader implements Component to get
numInitLinesToCache from CacheManager and use it in initial load.
Add implementation of get() function so data will also be loaded after
initial load.
3. APEXMALHAR-2475: CacheStore implements Component for passing readOnly
and numInitLinesToCache.
Added NO_EVICTION expire strategy. This strategy will be set in
setup(CacheContext) if readOnly is true.
@PramodSSImmaneni: please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oliverwnk/apex-malhar
APEXMALHAR-2473.cache-meta-info-support-in-CacheManager
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #605
----
commit 948fc9d85be95315a293aabddbce026943ae03d5
Author: Oliver Winke <oli...@datatorrent.com>
Date: 2017-04-17T18:27:01Z
APEXMALHAR-2473 Support for global cache meta information in db CacheManager
1. Uses Component interface and newly implemented CacheContext to pass
properties to the Stores by calling setup(CacheContext).
2. APEXMALHAR-2474: FSLoader implements Component to get
numInitLinesToCache from CacheManager and use it in initial load.
Add implementation of get() function so data will also be loaded after
initial load.
3. APEXMALHAR-2475: CacheStore implements Component for passing readOnly
and numInitLinesToCache.
Added NO_EVICTION expire strategy. This strategy will be set in
setup(CacheContext) if readOnly is true.
----
> Support for global cache meta information in db CacheManager
> ------------------------------------------------------------
>
> Key: APEXMALHAR-2473
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2473
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Pramod Immaneni
> Assignee: Oliver Winke
>
> Currently db CacheManager has no knowledge of characteristics of the data or
> the cache stores, so it handles all scenarios uniformly. This may not be the
> optimal implementation in all cases. Better optimizations can be performed in
> the manager if this information is known. A few examples, if the data is
> read-only the keys in the primary cache need not be refreshed like they are
> being done daily today, if the primary cache size is known the number of
> initial entries loaded from backup needn't exceed it. Add support for such
> general cache meta information in the manager.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
