+1 for all of them. Would rebase and commit record committer even if the rebase is a no-op.
On Thu, Jul 13, 2017 at 4:43 PM, Vlad Rozov <v.ro...@datatorrent.com> wrote: > OK, I agree, sorry for not sending a notification prior to filing an INFRA > ticket. Should we now focus on how new functionality affects contributors > and committers? > > 1. I checked with INFRA team and they recommend (strongly) to use github > for push (and pulls) even though push (and pull) to gitbox is also > available, so I suggest that we ask committers not to push to gitbox and > always use github (committers please check your upstream remote and set it > to https://github.com/apache/apex-core.git and remove > https://git-wip-us.apache.org/repos/asf/apex-core.git). > 2. I don't think that contribution process is affected by the change > except that those contributors that now have write access can assign > reviewers and assignees on github instead of using @ notification. > 3. Committers should use "rebase and commit" option when merging PR on > github. This option records both contributor and committer. I never tried > to use "squash and merge" possibly it provides the same functionality. > Option "create merge commit" should not be used. > 4. PR can be closed unmerged by committers. There is no need to use "this > closes" message in a commit. > > Thank you, > > Vlad > > > On 7/13/17 15:54, Pramod Immaneni wrote: > >> I wasn't focussing on the minor disruption. It was unexpected and that's >> ok. What I was saying is that it would have been good to know that we are >> adding this functionality or looking into adding it before it happened. >> >> Thanks >> >> On Thu, Jul 13, 2017 at 3:34 PM, Vlad Rozov <v.ro...@datatorrent.com> >> wrote: >> >> As I mentioned, it was not clear that enabling gitbox will lead to >>> operation disruption and change of an existing upstream. It sounded like >>> an >>> additional functionality when I learned about the opportunity to enable >>> write access on github, so I wanted to check how it works before >>> presenting >>> it to the community. I would bring it for the discussion should I expect >>> that the old https://git-wip-us.apache.org/repos/asf/apex-core.git will >>> stop working. >>> >>> Thank you, >>> >>> Vlad >>> >>> >>> On 7/13/17 15:18, Pramod Immaneni wrote: >>> >>> The integration is a good feature addition. Would be good to have had a >>>> heads up or a quick discussion unless I missed one. >>>> >>>> Thanks >>>> >>>> On Thu, Jul 13, 2017 at 2:31 PM, Vlad Rozov <v.ro...@datatorrent.com> >>>> wrote: >>>> >>>> It was not clear that the project needs to be removed from >>>> >>>>> https://git-wip-us.apache.org/repos/asf?p=apex-core.git to be enabled >>>>> for >>>>> gitbox. >>>>> >>>>> Thank you, >>>>> >>>>> Vlad >>>>> >>>>> >>>>> On 7/13/17 14:04, Pramod Immaneni wrote: >>>>> >>>>> Does this mean the repo is no longer available on asf? When was this >>>>> >>>>>> initiated? >>>>>> >>>>>> Thanks >>>>>> >>>>>> On Wed, Jul 12, 2017 at 8:22 PM, Vlad Rozov <v.ro...@datatorrent.com> >>>>>> wrote: >>>>>> >>>>>> Committers, >>>>>> >>>>>> See below. Now it is possible to merge PRs directly on github. Please >>>>>>> make >>>>>>> sure *not* to use "create merge commit" option. >>>>>>> >>>>>>> Thank you, >>>>>>> >>>>>>> Vlad >>>>>>> >>>>>>> >>>>>>> -------- Forwarded Message -------- >>>>>>> Subject: [jira] [Apache Infrastructure] Add Apache Apex to the >>>>>>> Gitbox [INFRA-14544] >>>>>>> Date: Thu, 13 Jul 2017 01:49:00 +0000 (UTC) >>>>>>> From: Daniel Takamori <j...@apache.org> >>>>>>> To: v.ro...@datatorrent.com >>>>>>> >>>>>>> >>>>>>> >>>>>>> Daniel Takamori commented on the request: Moved your repos to gitbox. >>>>>>> You'll need to have all your committers fill out >>>>>>> https://gitbox.apache.org/setup/ and enable 2 factor auth on Github >>>>>>> for >>>>>>> them to commit.... >>>>>>> *Apache Infrastructure* - GitBox Integration (GitHub-Writable Repo) < >>>>>>> https://issues.apache.org/jira/servicedesk/customer/portal/1> >>>>>>> Reference: >>>>>>> *INFRA-14544* <https://issues.apache.org/jir >>>>>>> a/servicedesk/customer/portal/ >>>>>>> 1/INFRA-14544> >>>>>>> >>>>>>> >>>>>>> Add Apache Apex to the Gitbox >>>>>>> <https://issues.apache.org/jira/servicedesk/customer/portal/ >>>>>>> 1/INFRA-14544 >>>>>>> Waiting for Infra >>>>>>> >>>>>>> >>>>>>> Daniel Takamori >>>>>>> >>>>>>> Today 01:48 >>>>>>> Moved your repos to gitbox. You'll need to have all your committers >>>>>>> fill >>>>>>> out https://gitbox.apache.org/setup/ and enable 2 factor auth on >>>>>>> Github >>>>>>> for them to commit. >>>>>>> >>>>>>> You can view the full request <https://issues.apache.org/jir >>>>>>> a/servicedesk/customer/portal/1/INFRA-14544> >>>>>>> >>>>>>> >>>>>>> Details >>>>>>> >>>>>>> Does your project have existing GitBox repos? No >>>>>>> Project Apex >>>>>>> Apache Git Repository Name(s) https://git-wip-us.apache.org/ >>>>>>> repos/asf?p=apex-core.git https://git-wip-us.apache.org/ >>>>>>> repos/asf?p=apex-malhar.git https://git-wip-us.apache.org/ >>>>>>> repos/asf?p=apex-site.git >>>>>>> GitHub Options Issues (disabled), Rebase and Merge (enabled) >>>>>>> >>>>>>> This message is automatically generated by JIRA Service Desk. >>>>>>> If you think it was sent incorrectly, please contact your JIRA >>>>>>> administrators. >>>>>>> For more information on JIRA Service Desk, see: >>>>>>> http://www.atlassian.com/software/jira/service-desk >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >
