[
https://issues.apache.org/jira/browse/APEXMALHAR-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283057#comment-16283057
]
ASF GitHub Bot commented on APEXMALHAR-2548:
--------------------------------------------
tweise closed pull request #682: APEXMALHAR-2548 Fixed XmlParserApplicationTest
test failure
URL: https://github.com/apache/apex-malhar/pull/682
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java
b/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java
index 51eaeee7ea..439a53b57e 100644
--- a/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java
+++ b/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java
@@ -24,6 +24,8 @@
import org.slf4j.LoggerFactory;
import org.apache.hadoop.classification.InterfaceStability;
+import com.google.common.base.Preconditions;
+
import com.datatorrent.api.Context;
@InterfaceStability.Evolving
@@ -57,9 +59,7 @@ public static URI getURI(String address)
public static URI getURI(String address, boolean useSSL)
{
- if (address == null) {
- throw new NullPointerException("No address specified");
- }
+ Preconditions.checkNotNull(address,"No address specified");
String uri = (useSSL ? "wss://" : "ws://") + address + "/pubsub";
logger.debug("PubSub uri {}", uri);
return URI.create(uri);
diff --git
a/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
b/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
index bd8b4a7b22..e35d6b0d1d 100644
---
a/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
+++
b/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
@@ -41,7 +41,7 @@
*/
public class XmlParserApplicationTest
{
- public static int TupleCount;
+ public static volatile int TupleCount;
public static com.datatorrent.lib.parser.XmlParserTest.EmployeeBean obj;
@Test
public void testApplication()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pubsub operators do not use the correct URL to connect to web socket server
> in SSL mode
> ---------------------------------------------------------------------------------------
>
> Key: APEXMALHAR-2548
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2548
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Pramod Immaneni
> Assignee: Pramod Immaneni
> Fix For: 4.0.0, 3.9.0
>
>
> In SSL mode, pub sub operators need to use wss protocol instead of ws. Today
> they use ws.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
