Github user ishark commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/98#discussion_r41455380
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -972,6 +943,52 @@ else if (allocatedContainers.isEmpty() && 
numRequestedContainers == 0 && dnmgr.c
         finishApplication(finalStatus, numTotalContainers);
       }
     
    +  public ResourceRequestHandler createResourceRequestor()
    --- End diff --
    
    Made these methods public because I want to mock these methods with 
mockito, which only allows mocking public methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to