Hi Justin, Once build there are several NOTICE files that do not match the top level > one. e.g. ./api/target/classes/META-INF/NOTICE. The notice in the final jar > under META-INF/NOTICE is incorrect. You may want to change NOTICE say > "Apache Apex (incubating)” rather than just “Apache Apex”. >
The NOTICE files are added to the .jar files by a plugin that is setup in the Apache POM. They come from org.apache:apache-jar-resource-bundle:1.4 I see examples of not matching the top level NOTICE elsewhere where this POM is used. I also see other releases with .jar artifacts that have no NOTICE file in it. The text in the non matching files is added by the plugin by substituting the Maven module name. So for example, the name element in api/pom.xml should be changed from "Apache Apex API" to "Apache Apex (incubating) API". What is your recommendation, same NOTICE file in all .jar artifacts or generated NOTICE file with (changed) name of module? > The url in the pom.xml is incorrect, it should be > http://apex.incubator.apache.org, I’d also change the name to "Apache > Apex (incubating)”. > <name>Apache Apex</name> > <url>http://apex.apache.org</url> > > Will fix that. > When checking what tagged in version control and what in the source > release I noticed: > - DEPENDANCIES file isn’t checked into version control > Is it recommended to have a top level DEPENDENCIES file in source control? - dt-app-archetype and dt-conf-archtype directories are not in version > control and are empty. Are these needed? > > Residual from build, will ensure they don't get packaged. > Finally is there a guide to making a release that any committer could > follow? > I took notes, will cleanup and publish along with release. https://malhar.atlassian.net/browse/APEX-216 Thanks, Thomas
