+1 - Tried rat check and built Apex successfully.
Thanks. Bhupesh On Tue, Oct 27, 2015 at 4:47 PM, Akshay Gore <[email protected]> wrote: > +1 > > I checked the following: > > - Built Apex with unit test execution, no issues > - mvn Apache rat check is clean > - CHANGELOG, LICENSE and NOTICE look good > - Built and packaged sample Apex app; launched it > > > Thanks, > > Akshay > > > On Tue, Oct 27, 2015 at 10:41 AM, Hitesh Shah <[email protected]> wrote: > > > +1 (binding) > > > > Checked the following: > > - signatures and checksums look fine. > > - DISCLAIMER, NOTICE, LICENSE look good. > > - mvn rat check is clean > > - code compiles and tests ran successfully. Though I ran "mvn install > > -DskipTests" and "mvn test" in that order if that makes a difference to > > anyone. > > > > Minor nits: > > - Release date in Changelog is a bit off. Currently it is set to when > > the vote started not when the eventually IPMC vote will eventually end. > > - I do not believe publishing the source release as a tarball to a > maven > > repo ( > > > https://repository.apache.org/content/repositories/orgapacheapex-1001/org/apache/apex/apex/3.2.0-incubating/ > > ) is a good idea. dist.apache.org is already available to host these > > release artifacts. This can be easily turned off via disabling the > > maven-deploy-plugin. > > - Future votes should have a pointer to the KEYS file and probably > point > > to " > > > https://dist.apache.org/repos/dist/dev/incubator/apex/v3.2.0-incubating-RC2/ > “ > > as the staging location. Also, publishing both a zip and tar.gz may be a > > bit of an overkill as every mirror has to now replicate both files. > > > > thanks > > — Hitesh > > > > On Oct 23, 2015, at 5:46 PM, Thomas Weise <[email protected]> > wrote: > > > > > Dear Community, > > > > > > We incorporated the feedback from RC1 and would like to start a new > vote. > > > > > > Please vote on the following Apache Apex Core 3.2.0-incubating release > > > candidate. > > > > > > This is the first release of the project since incubation. > > > > > > This is a source release. > > > > > > List of all issues fixed: http://s.apache.org/SRM > > > > > > Staged artifacts: > > > https://repository.apache.org/content/repositories/orgapacheapex-1001/ > > > Source zip: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/apex/v3.2.0-incubating-RC2/apex-3.2.0-incubating-source-release.zip > > > Source tar.gz: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/apex/v3.2.0-incubating-RC2/apex-3.2.0-incubating-source-release.tar.gz > > > > > > Git source: > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-apex-core.git;a=commit;h=refs/tags/v3.2.0-incubating-RC2 > > > (commit: d61ca617fd44bf9d74800838341f92018f2c7d10) > > > > > > PGP key: > > > *http://pgp.mit.edu:11371/pks/lookup?op=vindex&[email protected] > > > <http://pgp.mit.edu:11371/pks/lookup?op=vindex&[email protected]>* > > > > > > More information at: > > > http://apex.incubator.apache.org > > > > > > > > > Please try the release and vote; vote will be open for at least 72 > hours. > > > > > > [ ] +1 approve > > > [ ] -1 disapprove (and reason why) > > > > > > http://www.apache.org/foundation/voting.html > > > > > > Please add (binding) if your vote is binding. > > > > > > Please indicate what testing or verification was performed, especially > > for > > > binding votes. > > > > > > Thanks, > > > Thomas > > > > >
