Github user chandnisingh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/173#issuecomment-157638918
In this pull request, code in AbstractReservoir is copied from
DefaultReservoir but history and attribution doesn't reflect it.
DefaultReservoir is then renamed to ForwardingReservoir which has more new
changes (rather than old code which is moved to AbstractReservoir). In past
this is how we dealt with changes like this:
1. Renamed (with git) the existing class to the abstract. This will
preserve history.
2. Added a new extension. In this case ForwardingReservoir.
This was done to preserve history and it maybe a little tedious but most of
us have done it. This should be handled here as well. We cannot be selective
about when to force such rules and when to ignore it. Also IMO preserving
provenance of code is important.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
