Personally, I would prefer line length not to be enforced. But, I am curious to know how other projects in ASF are tackling this and would be happy to follow the same for Apex.
~ Yogi On 2 December 2015 at 11:08, Vlad Rozov <[email protected]> wrote: > +1 to keep 120 hard stop enforcement and not to rely on IDE formatting to > find wrapping point. I agree that wrapping string literal not always help > with readability, but overall I think that enforcing a hard stop on the > line length help with writing better code especially after going through an > exercise of fixing all code style violations in the buffer server. > Additionally some string literals may span multiple lines and will require > breaking anyway. > > Thank you, > > Vlad > > > On 12/1/15 21:19, Thomas Weise wrote: > >> A while ago, we discussed max length for line length enforcement and >> majority wanted to stop at 120 characters. >> >> Since then Vlad has fixed code style violations for one of the modules: >> >> https://github.com/apache/incubator-apex-core/pull/175 >> >> Before we continue I would like to put the line length enforcement back >> for >> poll. >> >> I think it leads to undesirable results, such as breaking string literals. >> There are also instances of questionable readability gains and the breaks >> still have to be manually handled due to unwelcome IDE auto-format. >> >> My preference would be not not enforce a line length. >> >> Opinions please. >> >> >
