Hi Chandni, I have moved that as well to lib, as the parsers depended on that.
Thanks, Isha On Wed, Dec 16, 2015 at 1:01 PM, Chandni Singh <[email protected]> wrote: > There is a converter package under com.datatorrent.contrib which has a > Converter API. This belongs in library as well. > > Thanks, > Chandni > > On Tue, Dec 15, 2015 at 1:29 PM, Chandni Singh <[email protected]> > wrote: > > > Isha, > > > > Thanks for moving this. When you move these files, please place then > under > > a package which reflects its functionality. I don't see the need for > > package called schema. > > > > Thanks, > > Chandni > > > > On Tue, Dec 15, 2015 at 12:31 PM, Isha Arkatkar <[email protected]> > > wrote: > > > >> Hi, > >> > >> For csv parser there is an additional dependency. So, I'll move only > >> json > >> and xml to new location. > >> > >> Thanks, > >> Isha > >> > >> On Tue, Dec 15, 2015 at 11:42 AM, Thomas Weise <[email protected]> > >> wrote: > >> > >> > As long as the operators don't introduce additional dependencies they > >> > should be in lib. > >> > > >> > > >> > On Tue, Dec 15, 2015 at 9:34 AM, Shubham Pathak < > >> [email protected]> > >> > wrote: > >> > > >> > > Hi Chandni, > >> > > > >> > > I had written those operators. > >> > > Here is the jira for that > >> https://malhar.atlassian.net/browse/MLHR-1838 > >> > > You would find the entire discussion there. > >> > > > >> > > Why are all these operator under Malhar/contrib and not Malhar/lib > >> > > When i was writing the code i saw AbstractCsvParser in contriib and > >> hence > >> > > added there. > >> > > > >> > > Recently i got to know which operators must go in contrib and what > >> must > >> > go > >> > > in lib. > >> > > By that definition, these operators must belong to lib. > >> > > > >> > > Thanks, > >> > > Shubham > >> > > > >> > > > >> > > On Tue, Dec 15, 2015 at 1:32 PM, Chandni Singh < > >> [email protected]> > >> > > wrote: > >> > > > >> > > > Hi, > >> > > > > >> > > > I just came across couple of formatter and parser operators which > >> are > >> > > under > >> > > > Malhar/contrib/schema. > >> > > > > >> > > > I have couple of questions: > >> > > > 1. What does schema denote here? > >> > > > 2. Why formatter/parser which are functions are placed under > schema > >> > > > package? > >> > > > 2. Why are all these operator under Malhar/contrib and not > >> Malhar/lib > >> > > > > >> > > > Thanks, > >> > > > Chandni > >> > > > > >> > > > >> > > >> > > > > >
